Re: Proposal for changes to recovery.conf API

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal for changes to recovery.conf API
Date: 2017-01-03 17:40:15
Message-ID: dddbc4e3-1f15-d4dc-f275-ac0e827eb67b@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/03/2017 08:47 AM, Robert Haas wrote:
> On Tue, Jan 3, 2017 at 11:21 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> On 3 January 2017 at 15:50, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> On Sun, Jan 1, 2017 at 4:14 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>>> Trying to fit recovery targets into one parameter was really not
>>>> feasible, though I tried.
>>>
>>> What was the problem?
>>
>> There are 5 different parameters that affect the recovery target, 3 of
>> which are optional. That is much more complex than the two compulsory
>> parameters suggested when the proposal was made and in my view tips
>> the balance over the edge into pointlessness. Michael's suggestion for
>> 2 parameters works well for this case.
>
> I still think merging recovery_target_type and recovery_target_value
> into a single parameter could make sense, never mind the other three.
> But I don't really want to argue about it any more.
>

Either solution works for me.

--
--
Josh Berkus
Red Hat OSAS
(any opinions are my own)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2017-01-03 17:41:03 Re: pgsql: Update copyright for 2017
Previous Message Bruce Momjian 2017-01-03 17:38:05 pgsql: Update copyright for 2017