| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: OpenFile() Permissions Refactor |
| Date: | 2017-09-23 14:22:17 |
| Message-ID: | dd470032-5c7b-f53e-8550-682f4e05bff6@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/13/17 10:26, David Steele wrote:
> Here's a new patch based on your review. Where I had a question I made
> a choice as described below:
I have committed the changes to the file APIs and a fix for the umask
save/restore issue.
The mkdir changes didn't really inspire me. Replacing mkdir() with
MakeDirectoryPerm() without any change in functionality doesn't really
improve clarity. Maybe we'll revisit that when your next patches arrive.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2017-09-23 14:38:32 | Re: user-defined numeric data types triggering ERROR: unsupported type |
| Previous Message | Andrew Dunstan | 2017-09-23 12:41:25 | Re: [BUGS] BUG #14825: enum type: unsafe use? |