Re: pgsql: Clean up Perl code according to perlcritic

On 03/27/2017 08:23 AM, Peter Eisentraut wrote:
> Clean up Perl code according to perlcritic
>
> Fix all perlcritic warnings of severity level 5, except in
> src/backend/utils/Gen_dummy_probes.pl, which is automatically generated.
>
> Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
> Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>

This contains at least one non-cosmetic change and the MSVC buildfarm
members have reacted accordingly:

@opts = grep {
- s/\Q$(top_builddir)\E/\"$topdir\"/;
- $_ !~ /\$\(/ && $_ =~ /^--/
+ my $x = $_;
+ $x =~ s/\Q$(top_builddir)\E/\"$topdir\"/;
+ $x !~ /\$\(/ && $x =~ /^--/

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services