Re: speeding up planning with partitions

From: Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: "Imai, Yoshikazu" <imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com>, 'Amit Langote' <amitlangote09(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: speeding up planning with partitions
Date: 2019-03-05 15:57:57
Message-ID: dcda0c1b-6360-193d-9c94-0113b0b905a1@redhat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/5/19 5:24 AM, Amit Langote wrote:
> Attached an updated version. This incorporates fixes for both Jesper's
> and Imai-san's review. I haven't been able to pin down the bug (or
> whatever) that makes throughput go down as the partition count increases,
> when tested with a --enable-cassert build.
>

Thanks !

I'm seeing the throughput going down as well, but are you sure it isn't
just the extra calls of MemoryContextCheck you are seeing ? A flamegraph
diff highlights that area -- sent offline.

A non cassert build shows the same profile for 64 and 1024 partitions.

Best regards,
Jesper

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-03-05 16:03:24 Re: Question about commit 11cf92f6e2e13c0a6e3f98be3e629e6bd90b74d5
Previous Message Tomas Vondra 2019-03-05 15:46:36 Re: Delay locking partitions during query execution