Re: AIX support

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Sriram RK <sriram(dot)rk(at)outlook(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "tvk1271(at)gmail(dot)com" <tvk1271(at)gmail(dot)com>, "sriram(dot)rk(at)in(dot)ibm(dot)com" <sriram(dot)rk(at)in(dot)ibm(dot)com>
Subject: Re: AIX support
Date: 2024-05-23 05:59:39
Message-ID: dc89bc84-c9a9-4792-8857-7eafc0234cfb@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 22.05.24 18:15, Sriram RK wrote:
> Please find the attached patch.
>
> Apart from the AIX specific changes, there is a minor change in this
> file wrt to XLC, below is the error for which we removed inline.
>
> Later, the build and tests passed for both XLC(16.1.0.18) and gcc(12) as
> well.

I think what you should do next is aggressively trim anything that does
not apply to current versions of AIX or the current compiler.

For example,

+ # Old xlc versions (<13.1) don't have support for -qvisibility. Use
expfull to force

+ <para>
+ <productname>AIX</productname> versions before 7.1 are no longer
+ tested nor supported by the <productname>PostgreSQL</productname>
+ community.
+ </para>

(Probably most of that section needs to be retested and rewritten.)

+ # Native memset() is faster, tested on:
+ # - AIX 5.1 and 5.2, XLC 6.0 (IBM's cc)
+ # - AIX 5.3 ML3, gcc 4.0.1
+ memset_loop_limit = 0

+ # for the base executable (AIX 4.2 and up)

+ * "IBM XL C/C++ for AIX, V12.1" miscompiles, for 32-bit, some inline

One of the reasons that the AIX port ultimately became unmaintainable
was that so many hacks and caveats were accumulated over the years. A
new port should set a more recent baseline and trim all those hacks.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2024-05-23 06:30:14 Re: Schema variables - new implementation for Postgres 15
Previous Message Peter Smith 2024-05-23 05:33:32 Re: Synchronizing slots from primary to standby