Re: Listen / Notify - what to do when the queue is full

From: Joachim Wieland <joe(at)mcknight(dot)de>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Smith <greg(at)2ndquadrant(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org, Arnaud Betremieux <arnaud(dot)betremieux(at)keyconsulting(dot)fr>
Subject: Re: Listen / Notify - what to do when the queue is full
Date: 2010-02-10 23:52:18
Message-ID: dc7b844e1002101552k1ae52530v95d3f94450e64fa3@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 8, 2010 at 5:16 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> These are the on-disk notifications, right?  It seems to me a bit
> wasteful to store channel name always as NAMEDATALEN bytes.  Can we
> truncate it at its strlen?

Attached is a new and hopefully more or less final patch for LISTEN / NOTIFY.

The following items have been addressed in this patch:

- only store strlen(channel) instead of NAMEDATALEN bytes on disk
- limit to 7-bit ASCII
- forbid 2PC and LISTEN/NOTIFY for now
- documentation changes
- add missing tab completion for NOTIFY
- fix pg_notify() behavior with respect to NULLs, too long and too
short parameters
- rebased to current HEAD, OID conflicts resolved

Joachim

Attachment Content-Type Size
listennotify.11.diff text/x-patch 109.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-02-10 23:58:04 Re: Writeable CTEs and empty relations
Previous Message Marko Tiikkaja 2010-02-10 23:25:22 Re: Writeable CTEs and empty relations