fixing pg_basebackup tests for modern Windows/msys2

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: fixing pg_basebackup tests for modern Windows/msys2
Date: 2021-07-28 13:31:05
Message-ID: dbed525d-f188-67d6-78fd-8c14dc9c34f6@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


While looking into issues with fairywren and pg_basebackup tests, I
created a similar environment but with more modern Windows / msys2.
Before it even got to the test that failed on fairywren it failed the
first TAP test for a variety of reasons, all connected to
TestLib::perl2host.

First, this function is in some cases returning paths for directories
with trailing slashes and or embedded double slashes.  Both of these can
cause problems, especially when written to a tablespace map file. Also,
the cygpath invocation is returning a path with backslashes whereas "pwd
-W' returns a path with forward slashes.

So the first attached patch rectifies these problems. It fixes issues
with doubles and trailing slashes and makes cygpath return a path with
forward slashes just like the non-cygpath branch.

However, there is another problem, which is that if called on a path
that includes a symlink, on the test platform I set up it actually
resolves that link rather than just following it. The end result is that
the use of a shorter path via a symlink is effectively defeated. I
haven't found any way to stop this behaviour.

The second patch therefore adjusts the test to avoid calling perl2host
on such a path. It just calls perl2host on the symlink's parent, and
thereafter uses that result.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
0001-Make-TestLib-perl2host-more-consistent-and-robust.patch text/x-patch 1.5 KB
0002-Avoid-calling-TestLib-perl2host-on-a-symlinked-direc.patch text/x-patch 2.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-07-28 13:32:16 Re: when the startup process doesn't (logging startup delays)
Previous Message Robert Haas 2021-07-28 13:27:18 Re: .ready and .done files considered harmful