Re: Add “FOR UPDATE NOWAIT” lock details to the log.

From: Yuki Seino <seinoyu(at)oss(dot)nttdata(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add “FOR UPDATE NOWAIT” lock details to the log.
Date: 2024-12-19 08:21:20
Message-ID: dbbb53f8-de17-4698-b458-c524dd8e8641@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I will design a new GUC while ensuring consistency with 'log_lock_waits'.
>
>> Regarding the patch, when I applied it to HEAD, it failed to compile
>> with
>> the following errors. Could you update the patch to address this?
>>
>> proc.c:1538:20: error: use of undeclared identifier 'buf'
>>  1538 |                         initStringInfo(&buf);
>>       |                                         ^
>> proc.c:1539:20: error: use of undeclared identifier 'lock_waiters_sbuf'
>>  1539 | initStringInfo(&lock_waiters_sbuf);
>>       |                                         ^
>> proc.c:1540:20: error: use of undeclared identifier 'lock_holders_sbuf'
>>  1540 | initStringInfo(&lock_holders_sbuf);
>>       |                                         ^
>> ....
>
> Conflicted with another commit [1]. I'll rebase it later.
>
>
> [1]
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=3c0fd64fec8ed6fa3987c33f076fcffbc3f268c3
Rebased and added new GUC log_lock_failure and minor fixes. Currently
only NOWAIT errors are supported.
I would like to revisit the possibility of extending this GUC to include
client cancellations and lock timeouts at another opportunity.

--
Regards,
Yuki Seino
NTT DATA GROUP CORPORATION

Attachment Content-Type Size
v5-0001_add_log_lock_failure.patch text/plain 8.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2024-12-19 09:15:10 Re: BitmapHeapScan streaming read user and prelim refactoring
Previous Message Pavel Stehule 2024-12-19 07:25:51 Re: proposal: schema variables