Re: Amcheck verification of GiST and GIN

On 2/21/25 18:07, Mark Dilger wrote:
>
>
>> On Feb 21, 2025, at 6:29 AM, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>>
>> Hi,
>>
>> I see this patch didn't move since December :-( I still think
>> these improvements would be useful, it certainly was very helpful
>> when I was working on the GIN/GiST parallel builds (the GiST
>> builds stalled, but I hope to push the GIN patches soon).
>>
>> So I'd like to get some of this in too. I'm not sure about the
>> GiST bits, because I know very little about that AM (the parallel
>> builds made me acutely aware of that).
>>
>> But I'd like to get the GIN parts in. We're at v34 already, and
>> the recent changes were mostly cosmetic. Does anyone object to me
>> polishing and pushing those parts?
>
> I infer that you intend to make v34-0004, v34-0006, and v35-0001
> apply cleanly without the other patches and commit it that way. If
> that is correct, be advised that I'm doing a review and will respond
> back shortly, maybe in a few hours.
>

Something like that. I haven't tried to actually massage the patches
yet, maybe it'd require some of the refactoring patches too.

But OK, I'll wait for the review, no problem. I wouldn't get to this
until Monday anyway.

regards

--
Tomas Vondra