From: | Ken Kato <katouknl(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] ALTER tab completion |
Date: | 2021-11-26 08:00:44 |
Message-ID: | dad8911a89a495a1de9025d9451c3495@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Thank you for the comments!
I made following updates:
>> -ALTER DEFAULT PRIVILEGES: missing FOR USER
>
> FOR ROLE is an equivalent. That does not seem mandatory to me.
I deleted the completion for "FOR USER".
>> -ALTER VIEW: no completion after ALTER COLUMN column_name
> + /* ALTER VIEW xxx ALTER yyy */
> + else if (Matches("ALTER", "VIEW", MatchAny, "ALTER", MatchAny))
> + COMPLETE_WITH("SET DEFAULT", "DROP DEFAULT");
> It may be cleaner to group this one with "ALTER VIEW xxx ALTER yyy"
> two blocks above.
I put them back to back so that it looks cleaner.
>> -ALTER SEQUENCE: missing AS
> + /* ALTER SEQUENCE <name> AS */
> + else if (TailMatches("ALTER", "SEQUENCE", MatchAny, "AS"))
> + COMPLETE_WITH("smallint", "integer", "bigint");
> Re-quoting Horiguchi-san, that should be COMPLETE_WITH_CS() to keep
> these completions in lower case.
That's what it's for.
I used COMPLETE_WITH_CS instead of COMPLETE_WITH.
Best wishes,
--
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachment | Content-Type | Size |
---|---|---|
alter_tab_completion.patch | text/x-diff | 2.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Nikolay Shaplov | 2021-11-26 08:19:16 | Re: Suggestion: Unified options API. Need help from core team |
Previous Message | Michael Paquier | 2021-11-26 06:55:11 | Re: pg_dump, pg_basebackup don't error out with wrong option for "--format" |