| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea) |
| Date: | 2017-03-04 13:08:45 |
| Message-ID: | dac4e29a-6ecc-a905-f1ac-5d59f1b794fb@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/3/17 09:03, Tomas Vondra wrote:
> Damn. In my defense, the patch was originally created for an older
> PostgreSQL version (to investigate issue on a production system), which
> used that approach to building values. Should have notice it, though.
>
> Attached is v2, fixing both issues.
Can we have a test case for page_checksum(), or is that too difficult to
get running deterministicly?
Also, perhaps page_checksum() doesn't need to be superuser-only, but I
can see arguments for keeping it that way for consistency.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-04 13:18:16 | Re: [FEATURE PATCH] pg_stat_statements with plans |
| Previous Message | Michael Paquier | 2017-03-04 11:02:46 | Re: pg_dump, pg_dumpall and data durability |