Re: Apply PGDLLIMPORT markings to some GUC variables

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Sofia Kopikova <s(dot)kopikova(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Apply PGDLLIMPORT markings to some GUC variables
Date: 2024-08-19 09:20:33
Message-ID: da997cd8-4e63-4a4b-ab09-8b51b4d19b2a@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19.08.24 08:18, Michael Paquier wrote:
> On Tue, Aug 13, 2024 at 03:00:00PM -0400, Robert Haas wrote:
>> This seems correct to me.
>
> It is not the first time that this happens in recent history. Would
> it be worth automating that? I would guess a TAP test that takes a
> copy of the headers, applies the changes while filtering the few
> exceptions, then compares it to the origin in the tree?

Probably worth thinking about, but it would at least require some kind
of exclude list, because there are exceptions like src/include/common/
/logging.h.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2024-08-19 09:32:48 Re: Vacuum statistics
Previous Message Jelte Fennema-Nio 2024-08-19 09:04:19 Re: gitmaster server problem?