| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: client-side fsync() error handling |
| Date: | 2020-02-24 16:03:07 |
| Message-ID: | da539e2f-3d0f-65ec-44d8-8e37c3b0a4f7@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-02-21 05:18, Michael Paquier wrote:
> On Thu, Feb 20, 2020 at 10:10:11AM +0100, Peter Eisentraut wrote:
>> OK, added in new patch.
>
> Thanks, that looks good.
committed
>> The frontends do neither right now, or at least the error handling is very
>> inconsistent and inscrutable. It would be possible in theory to add a retry
>> option, but that would be a very different patch, and given what we have
>> learned about fsync(), it probably wouldn't be widely useful.
>
> Perhaps. Let's have this discussion later if there are drawbacks
> about changing things the way your patch does. If we don't do that,
> we'll never know about it either and this patch makes things safer.
yup
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2020-02-24 16:34:03 | Re: DB running out of memory issues after upgrade |
| Previous Message | Tom Lane | 2020-02-24 14:50:53 | Re: PG v12.2 - Setting jit_above_cost is causing the server to crash |