| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: color by default |
| Date: | 2020-04-01 13:50:42 |
| Message-ID: | da433a28-6db9-48fc-7631-dfeb76f24392@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-03-30 10:03, Michael Paquier wrote:
> On Sun, Mar 29, 2020 at 02:55:37PM +0200, Juan José Santamaría Flecha wrote:
>> Add it to the tests done when PG_COLOR is "auto".
>
> FWIW, I am not sure that it is a good idea to stick into the code
> knowledge inherent to TERM. That would likely rot depending on how
> terminals evolve in the future, and it is easy to test if a terminal
> supports color or not but just switching PG_COLOR in a given
> environment and look at the error message produced by anything
> able to support coloring.
There could be some value in this, I think. Other systems also do this
in some variant. However, it's unclear to me to what extent this is
legacy behavior or driven by current needs. I'd be willing to refine
this, but it should be based on some actual needs. What terminals (or
terminal-like things) don't support color, and how do we detect them?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-04-01 13:52:17 | Re: color by default |
| Previous Message | Dilip Kumar | 2020-04-01 13:50:31 | Re: WAL usage calculation patch |