| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Joe Nelson <joe(at)begriffs(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | david(dot)rowley(at)2ndquadrant(dot)com, ashu(dot)coek88(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, michael(at)paquier(dot)xyz, tomas(dot)vondra(at)2ndquadrant(dot)com, surafel3000(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org, alvherre(at)2ndquadrant(dot)com |
| Subject: | Re: Change atoi to strtol in same place |
| Date: | 2020-01-09 09:49:10 |
| Message-ID: | d9787691-7d5d-e3e0-f527-1bb152945c7c@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-12-06 18:43, Joe Nelson wrote:
> I see this patch has been moved to the next commitfest. What's the next
> step, does it need another review?
I think you need to promote your patch better. The thread subject and
the commit fest entry title are somewhat nonsensical and no longer match
what the patch actually does. The patch contains no commit message and
no documentation or test changes, so it's not easy to make out what it's
supposed to do or verify that it does so correctly. A reviewer would
have to take this patch on faith or manually test every single command
line option to see what it does. Moreover, a lot of this error message
tweaking is opinion-based, so it's more burdensome to do an objective
review. This patch is competing for attention against more than 200
other patches that have more going for them in these aspects.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-01-09 09:56:32 | Re: Remove libpq.rc, use win32ver.rc for libpq |
| Previous Message | Fabien COELHO | 2020-01-09 09:28:21 | Re: pgbench - use pg logging capabilities |