Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput?

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
Cc: "David Pirotte" <dpirotte(at)gmail(dot)com>, "Ashutosh Bapat" <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "Dave Cramer" <davecramer(at)gmail(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz>, "Andres Freund" <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Ashutosh Bapat" <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Subject: Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput?
Date: 2021-04-02 23:55:52
Message-ID: d97788f6-c1d9-4990-9e96-feada353da71@www.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 1, 2021, at 7:19 AM, Amit Kapila wrote:
> Your ideas/suggestions look good to me. Don't we need to provide a
> read function corresponding to logicalrep_write_message? We have it
> for other write functions. Can you please combine all of your changes
> into one patch?
Thanks for taking a look at this patch. I didn't consider a
logicalrep_read_message function because the protocol doesn't support it yet.

/*
* Logical replication does not use generic logical messages yet.
* Although, it could be used by other applications that use this
* output plugin.
*/

Someone that is inspecting the code in the future could possibly check this
discussion to understand why this function isn't available.

This new patch set version has 2 patches that is because there are 2 separate
changes: parse_output_parameters() refactor and logical decoding message
support.

--
Euler Taveira
EDB https://www.enterprisedb.com/

Attachment Content-Type Size
v3-0001-Refactor-function-parse_output_parameters.patch text/x-patch 4.3 KB
v3-0002-Logical-decoding-message-support-to-pgoutput.patch text/x-patch 13.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-04-02 23:58:15 Re: Have I found an interval arithmetic bug?
Previous Message Bruce Momjian 2021-04-02 23:49:43 Re: Have I found an interval arithmetic bug?