From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
---|---|
To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Add support for building GiST index by sorting. |
Date: | 2020-09-17 20:26:45 |
Message-ID: | d8727aed-4d04-7d8b-b595-a1a59acb66c8@iki.fi |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 17/09/2020 23:07, Peter Geoghegan wrote:
> On Thu, Sep 17, 2020 at 1:34 AM Heikki Linnakangas
> <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>> Add support for building GiST index by sorting.
>
> You forgot to bump catversion, despite your best efforts. :-)
>
> You left this behind:
>
> +/* FIXME: bump this before pushing! */
>
> I have settled on a system for this: I write myself a reminder on a
> prominently placed post-it note, days in advance of commit. I rarely
> have to bump catversion (due to the kinds of things I work on), and
> iso t's just too easy to forget any other way.
D'oh! I think I'm going to write a git post-push hook for this.
Apparently even a FIXME comment in the code is not enough of a reminder
to me.
Thanks for fixing it, Tom.
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-09-17 23:38:17 | pgsql: Remove support for postfix (right-unary) operators. |
Previous Message | Tom Lane | 2020-09-17 20:20:37 | Re: pgsql: Add support for building GiST index by sorting. |