| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Collation versions on Windows (help wanted, apply within) |
| Date: | 2019-11-26 21:38:06 |
| Message-ID: | d86fd312-ae0c-1380-f860-46ae711116d6@2ndquadrant.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-11-26 21:39, Thomas Munro wrote:
> On Fri, Nov 8, 2019 at 12:44 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>> The reason for returning an empty string for "C" and "POSIX" is the
>> following comment for get_collation_actual_version():
>>
>> * A particular provider must always either return a non-NULL string or return
>> * NULL (if it doesn't support versions). It must not return NULL for some
>> * collcollate and not NULL for others.
>>
>> I'm not sure why, or if that really makes sense.
>
> Peter E, do you have any thoughts on this question?
Doesn't make sense to me either.
We need to handle the various combinations of null and non-null stored
and actual versions, which we do, but that only applies within a given
collcollate. I don't think we need the property that that comment calls
for.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2019-11-26 22:09:55 | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
| Previous Message | Peter Eisentraut | 2019-11-26 21:10:15 | Re: [HACKERS] Regression tests vs existing users in an installation |