Re: daitch_mokotoff module

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dag Lem <dag(at)nimrod(dot)no>
Cc: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: daitch_mokotoff module
Date: 2023-04-08 02:50:32
Message-ID: d7fdb2fe-e0b0-ce35-827d-41cdfab655ef@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-04-07 Fr 21:52, Tom Lane wrote:
> I wrote:
>> I pushed this after some mostly-cosmetic fiddling. Most of the
>> buildfarm seems okay with it,
> Spoke too soon [1]:
>
> make[1]: Entering directory '/home/linux1/build-farm-16-pipit/buildroot/HEAD/pgsql.build/contrib/fuzzystrmatch'
> '/usr/bin/perl' daitch_mokotoff_header.pl daitch_mokotoff.h
> Can't locate open.pm in @INC (you may need to install the open module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at daitch_mokotoff_header.pl line 15.
> BEGIN failed--compilation aborted at daitch_mokotoff_header.pl line 15.
> make[1]: *** [Makefile:33: daitch_mokotoff.h] Error 2
>
> pipit appears to be running a reasonably current system (RHEL8), so
> the claim that "open" is a Perl core module appears false. We need
> to rewrite this to not use that.
>
> regards, tom lane
>
> [1]https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pipit&dt=2023-04-08%2001%3A02%3A39
>
>

I think it is a core module (See <https://metacpan.org/pod/open>) but it
appears that some packagers have separated it out for reasons that
aren't entirely obvious:

andrew(at)emma:~ $ rpm -q -l -f /usr/share/perl5/open.pm
/usr/share/man/man3/open.3pm.gz
/usr/share/perl5/open.pm

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2023-04-08 02:53:53 Re: Partial aggregates pushdown
Previous Message Tom Lane 2023-04-08 02:50:18 Re: longfin missing gssapi_ext.h