| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Logger process and "LOG: could not close client or listen socket: Bad file descriptor" |
| Date: | 2023-08-29 06:27:48 |
| Message-ID: | d7c4cede-08db-1197-b92b-67f8d5294efa@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29/08/2023 06:18, Peter Geoghegan wrote:
> On Sun, Aug 27, 2023 at 5:52 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> From what I can see, this is is a rather old issue, because
>> ListenSocket[] is filled with PGINVALID_SOCKET *after* starting the
>> syslogger. It seems to me that we should just initialize the array
>> before starting the syslogger, so as we don't get these incorrect
>> logs?
>>
>> Thoughts? Please see the attached.
>
> Agreed, this is very annoying. I'm going to start using your patch
> with the feature branch I'm working on. Hopefully that won't be
> necessary for too much longer.
Just to close the loop on this thread: I committed and backpatched
Michael's fix.
Discussion on other thread at
https://www.postgresql.org/message-id/9caed67f-f93e-5701-8c25-265a2b139ed0%40iki.fi.
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-08-29 06:30:46 | Re: Logger process and "LOG: could not close client or listen socket: Bad file descriptor" |
| Previous Message | Amit Kapila | 2023-08-29 06:24:18 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |