| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add reject_limit option to file_fdw |
| Date: | 2024-11-11 16:49:34 |
| Message-ID: | d7a03664-bef5-49b0-998f-3ea5356b53c9@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024/11/11 21:45, torikoshia wrote:
>> Thanks for adding the comment. It clearly states that REJECT_LIMIT can be
>> a single-quoted string. However, it might also be helpful to mention that
>> it can be provided as an int64 in the COPY command option. How about
>> updating it like this?
>>
>> ------------------------------------
>> REJECT_LIMIT can be specified in two ways: as an int64 for the COPY command
>> option or as a single-quoted string for the foreign table option using
>> file_fdw. Therefore this function needs to handle both formats.
>> ------------------------------------
>
> Thanks! it seems better.
>
>
> Attached v3 patch.
Thanks for updating the patch! It looks like you forgot to attach it, though.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-11-11 17:07:51 | Re: define pg_structiszero(addr, s, r) |
| Previous Message | Bernd Helmle | 2024-11-11 16:41:25 | Re: [PATCH] Add sortsupport for range types and btree_gist |