Re: Add Information during standby recovery conflicts

From: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add Information during standby recovery conflicts
Date: 2021-01-08 06:42:46
Message-ID: d74412a7-b037-4a49-34a9-491ebba99dd1@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 1/8/21 7:24 AM, Fujii Masao wrote:
> CAUTION: This email originated from outside of the organization. Do
> not click links or open attachments unless you can confirm the sender
> and know the content is safe.
>
>
>
> On 2021/01/08 14:02, Drouvot, Bertrand wrote:
>> Hi,
>>
>> On 1/7/21 4:51 PM, Fujii Masao wrote:
>>> Thanks for the review! I pushed the latest patch.
>>>
>> Thanks all of you for your precious help on this patch!
>>
>> The original idea behind this thread has been split into 3 pieces.
>>
>> Pieces 1 (9d0bd95fa90a7243047a74e29f265296a9fc556d) and 2
>> (0650ff23038bc3eb8d8fd851744db837d921e285) have now been committed,
>> the last one is to add more information regarding the canceled
>> statements (if any), like:
>>
>> * What was the blocker(s) doing?
>
> This "canceled statement" is just one that's canceled by recovery
> conflict?
> If so, the blocker is always the startup process? Sorry maybe I fail to
> understand this idea well..
>
>
By blocker, I meant the one being canceled (I had in mind the startup
process being the blocked one, not the blocker one). Sorry if i have not
been clear enough.

As an example, it could provide things like:

2020-06-15 06:48:54.778 UTC [7037] LOG: about to interrupt pid: 7037,
backend_type: client backend, state: active, wait_event_type: Timeout,
wait_event: PgSleep, query_start: 2020-06-15 06:48:13.008427+00
2020-06-15 06:48:54.778 UTC [7037] ERROR: canceling statement due to
conflict with recovery

> Anyway if you post the patch, I'm happy to review that!

Thanks!

Bertrand

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-01-08 06:49:03 Re: Huge memory consumption on partitioned table with FKs
Previous Message Fujii Masao 2021-01-08 06:24:36 Re: Add Information during standby recovery conflicts