| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Asim R P <apraveen(at)pivotal(dot)io>, pgsql-hackers(at)postgresql(dot)org, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Subject: | default_table_access_method is not in sample config file |
| Date: | 2019-08-09 08:34:05 |
| Message-ID: | d6ffbebb-a0d2-181c-811d-b029b2225ed7@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/04/2019 19:49, Andres Freund wrote:
> On 2019-04-11 14:52:40 +0300, Heikki Linnakangas wrote:
>> diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
>> index f7f726b5aec..bbcab9ce31a 100644
>> --- a/src/backend/utils/misc/guc.c
>> +++ b/src/backend/utils/misc/guc.c
>> @@ -3638,7 +3638,7 @@ static struct config_string ConfigureNamesString[] =
>> {"default_table_access_method", PGC_USERSET, CLIENT_CONN_STATEMENT,
>> gettext_noop("Sets the default table access method for new tables."),
>> NULL,
>> - GUC_IS_NAME
>> + GUC_NOT_IN_SAMPLE | GUC_IS_NAME
>> },
>> &default_table_access_method,
>> DEFAULT_TABLE_ACCESS_METHOD,
>
> Hm, I think we should rather add it to sample. That's an oversight, not
> intentional.
I just noticed that this is still an issue. default_table_access_method
is not in the sample config file, and it's not marked with
GUC_NOT_IN_SAMPLE. I'll add this to the open items list so we don't forget.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-08-09 08:39:16 | Re: POC: Cleaning up orphaned files using undo logs |
| Previous Message | Amit Kapila | 2019-08-09 08:29:14 | Re: POC: Cleaning up orphaned files using undo logs |