Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
Date: 2021-10-20 21:27:26
Message-ID: d6fe7d77-314c-0332-209f-b1294424d37d@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 10/20/21 3:09 PM, Andres Freund wrote:
> Hi,
>
> On 2021-10-20 14:30:49 -0400, Andrew Dunstan wrote:
>> On 10/20/21 12:31 PM, Andres Freund wrote:
>>> ISTM that we should just make the "test invocation framework" responsible to
>>> put the relevant directory onto PATH? I.e. Makefile.global should add the
>>> build directory of the test to PATH, and vcregress.pl should put the relevant
>>> $configuration/$project/ directory there?
>> Like this? That seems reasonable.
> Yea, that's along the lines of what I was thinking...
>

OK, it turns out that it's better to put the addition at the end of the
PATH, otherise initdb complains that it can't find postgres in the same
directory.

This patch has been tested on Linux but not yet on Windows/MSVC,
although I have little doubt it will work there too.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
libpq_pipeline_fix4.patch text/x-patch 2.9 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-10-20 21:48:39 Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
Previous Message Andres Freund 2021-10-20 19:09:16 Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.