From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de>, Dave Cramer <davecramer(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndQuadrant(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: patch to ensure logical decoding errors early |
Date: | 2018-08-01 14:13:39 |
Message-ID: | d5b7c6e4-fdd6-a94a-5824-00d28a69052f@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 31/07/18 20:58, Andres Freund wrote>
>> diff --git a/src/backend/replication/logical/logical.c b/src/backend/replication/logical/logical.c
>> index 3cd4eef..9f883b9 100644
>> --- a/src/backend/replication/logical/logical.c
>> +++ b/src/backend/replication/logical/logical.c
>> @@ -143,8 +143,7 @@ StartupDecodingContext(List *output_plugin_options,
>> * (re-)load output plugins, so we detect a bad (removed) output plugin
>> * now.
>> */
>> - if (!fast_forward)
>> - LoadOutputPlugin(&ctx->callbacks, NameStr(slot->data.plugin));
>> + LoadOutputPlugin(&ctx->callbacks, NameStr(slot->data.plugin));
>
> So this actually was broken by 9c7d06d60680c7f00d931233873dee81fdb311c6
> and worked before? Petr, Simon? Isn't the actual bug here that
> CreateInitDecodingContext() passes true for fast_forward? Dave, could
> you confirm this is the case? If so, this'll end up actually being an
> open items entry...
>
Indeed.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Verite | 2018-08-01 14:20:02 | Re: Allow COPY's 'text' format to output a header |
Previous Message | Dave Cramer | 2018-08-01 14:08:38 | Re: patch to ensure logical decoding errors early |