| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Paul Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: SQL:2011 application time |
| Date: | 2024-11-13 10:50:54 |
| Message-ID: | d4c5de4d-ff2d-4ef6-b7a2-1787dfa6427b@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
A quick comment on the patch
v43-0005-Add-UPDATE-DELETE-FOR-PORTION-OF.patch
regarding the code in transformForPortionOfClause() and the additions
you made to lsyscache.c:
What you are doing is taking a type OID and a function OID and then
converting them back to name and namespace and then building a node and
then feeding that node back through the parse analysis transformation.
This all seems quite fishy and cumbersome. I think instead of building
a FuncCall and transforming it, try to build a FuncExpr directly. Then
you wouldn't need these new helper functions, which would also reduce
the surface area of your patch.
Additional mini-comment:
#include "utils/rangetypes.h"
in src/include/nodes/execnodes.h appears to be unnecessary (but it is
then required in src/backend/commands/trigger.c).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-11-13 10:53:06 | Re: SQL:2011 application time |
| Previous Message | Andrei Lepikhov | 2024-11-13 10:36:10 | Re: Reordering DISTINCT keys to match input path's pathkeys |