revise a comment in CreateCheckPoint()

From: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
To: pgsql-patches(at)postgresql(dot)org
Subject: revise a comment in CreateCheckPoint()
Date: 2005-04-21 10:12:03
Message-ID: d47uda$op6$1@news.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

The original comment of why we are safe without protection of critical
section is confusing.

Index: xlog.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/access/transam/xlog.c,v
retrieving revision 1.187
diff -c -r1.187 xlog.c
*** xlog.c 17 Apr 2005 03:04:29 -0000 1.187
--- xlog.c 21 Apr 2005 10:12:01 -0000
***************
*** 4924,4931 ****
* buffers and commit-log buffers are flushed to disk.
*
* This I/O could fail for various reasons. If so, we will fail to
! * complete the checkpoint, but there is no reason to force a system
! * panic. Accordingly, exit critical section while doing it.
*/
END_CRIT_SECTION();

--- 4924,4934 ----
* buffers and commit-log buffers are flushed to disk.
*
* This I/O could fail for various reasons. If so, we will fail to
! * complete the checkpoint, there is no problem if this occurs in
! * ordinary situtations but it could be a problem if we are shutdown
! * database. However, we increase the CritSectionCount in
ShutdownXLOG()
! * already, so it is ok. Accordingly, exit critical section while
! * doing it.
*/
END_CRIT_SECTION();

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-04-21 13:57:40 Re: BUG #1609: Bug in interval datatype for 64 Bit timestamps
Previous Message Oliver Siegmar 2005-04-21 07:10:02 Re: BUG #1609: Bug in interval datatype for 64 Bit timestamps