| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org, Jacob Champion <pchampion(at)vmware(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: alter table set TABLE ACCESS METHOD |
| Date: | 2021-06-09 19:31:28 |
| Message-ID: | d47f55de936b6808e5d5e3177b410d1e0909faa1.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2021-06-09 at 13:47 +0900, Michael Paquier wrote:
> There is a mix of upper and lower-case characters here. It could be
> more consistent. It seems to me that this test should actually check
> that pg_class.relam reflects the new value.
Done. I also added a (negative) test for changing the AM of a
partitioned table, which wasn't caught before.
> + errmsg("cannot have multiple SET ACCESS METHOD
> subcommands")));
> Worth adding a test?
Done.
> Nit: the name of the variable looks inconsistent with this comment.
> The original is weird as well.
Tried to improve wording.
> I am wondering if it would be a good idea to set the new tablespace
> and new access method fields to InvalidOid within
> ATGetQueueEntry. We
> do that for the persistence. Not critical at all, still..
Done.
> + pass = AT_PASS_MISC;
> Maybe add a comment here?
Done. In that case, it doesn't matter because there's no work to be
done in Phase 2.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-ALTER-TABLE-.-SET-ACCESS-METHOD.patch | text/x-patch | 18.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-06-09 19:34:53 | Re: Add PortalDrop in exec_execute_message |
| Previous Message | Magnus Hagander | 2021-06-09 19:30:52 | Re: Estimating HugePages Requirements? |