Re: pgsql: Generate syscache info from catalog files

On 23.01.24 15:08, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> Generate syscache info from catalog files
>
> Per guaibasaurus[1], this commit broke "make dist":
>
> ...
> rm -rf tmp_install/ portlock/
> rm -f config.cache config.log config.status GNUmakefile
> make[1]: Leaving directory '/home/pgsql/buildfarm/buildroot/HEAD/pgsql.build/postgresql-17devel'
> /bin/tar chf postgresql-17devel.tar postgresql-17devel
> /bin/tar: postgresql-17devel/src/include/catalog/syscache_ids.h: File removed before we read it
> /bin/tar: postgresql-17devel/src/include/catalog/syscache_info.h: File removed before we read it
> make: *** [GNUmakefile:94: postgresql-17devel.tar] Error 1
> make: *** Deleting file 'postgresql-17devel.tar'
>
> I'm not sure why --- the makefile changes treat these new files
> exactly like other generated files. It doesn't repro here,
> either, which is odd. It looks like a timing problem, but how
> could there be one?

I have found that the files are not listed in the clean target in
src/include/Makefile. That might explain it, but it's gotta be fixed
anyway. I'll go ahead with that.