Re: log_autovacuum

From: NikhilS <nikkhils(at)gmail(dot)com>
To: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
Cc: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: log_autovacuum
Date: 2007-03-09 06:29:17
Message-ID: d3c4af540703082229t5b7bdd5ck20e1df3adac757fc@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches pgsql-www

Hi,

On 3/9/07, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>
> On Thu, 2007-03-08 at 14:53 -0300, Alvaro Herrera wrote:
> > Maybe something like this is better:
> >
> > LOG: index passes: 1 pages: removed 0, 197 remain tuples: removed
> 7199, 2338 remain CPU usage: whatever
> > CONTEXT: Automatic vacuuming of table "database.public.w"
>
> Yours is better.
>
> I've implemented this:
>
> LOG: autovac "public.w" index passes: 1 pages: removed 0, 197 remain
> tuples: removed 7199, 2338 remain CPU usage: whatever
>
> I'm happy if this gets removed later, but I think it will help everybody
> understand how multi-vacuums are working and what the best way to
> specify the controls should be.
>
> Not sure about the CONTEXT bit. I think its verbose, plus I thought that
> was for ERRORs only. I will defer on this point, since I know y'all
> understand that better than I.

IMHO, it would be good to have both the messages spit out. The earlier
message is much better for parsing and the later makes READABLE sense.

Regards,
Nikhils

--
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Zeugswetter Andreas ADI SD 2007-03-09 09:31:27 Re: Auto creation of Partitions
Previous Message NikhilS 2007-03-09 06:23:04 Re: Auto creation of Partitions

Browse pgsql-www by date

  From Date Subject
Next Message Josh Berkus 2007-03-09 22:51:37 Updated summerofcode pages
Previous Message Simon Riggs 2007-03-08 18:31:36 Re: log_autovacuum