From: | NikhilS <nikkhils(at)gmail(dot)com> |
---|---|
To: | "Greg Smith" <gsmith(at)gregsmith(dot)com> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: New features for pgbench |
Date: | 2007-02-12 06:47:17 |
Message-ID: | d3c4af540702112247o771a2b6fud17ce8d9399b529f@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Hi,
On 2/12/07, Greg Smith <gsmith(at)gregsmith(dot)com> wrote:
>
> The attached adds two new command line switches to pgbench:
>
> -x: Generate extended detail in the latency log, including a timestamp
> for each transaction
From your patch I see that it augments the -l flag. IMHO it does not make
sense to add another flag. We can save the "if" check and log the extended
contents as part of -l itself.
-X: Do extra cleanup after the run (vacuum on all tables, checkpoint)
> before stopping the clock. This gives substantially more consistancy in
> results between runs.
I am sorry, but I do not understand the above. If I read it correctly, are
you suggesting that the same database with a prior pgbench run be used for
further pgbench runs? How is it useful? How can one guarantee consistency of
observed tps values with this in place?
Regards,
Nikhils
--
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Smith | 2007-02-12 15:32:49 | Re: New features for pgbench |
Previous Message | Tom Lane | 2007-02-12 05:21:22 | Re: New features for pgbench |