| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: pg_waldump: Add a --quiet option. |
| Date: | 2020-04-03 01:41:09 |
| Message-ID: | d332b8f0-0c72-3cd6-6945-7a86a503662a@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2020/04/03 10:11, Robert Haas wrote:
> pg_waldump: Add a --quiet option.
>
> The primary motivation for this change is that it will be used by the
> upcoming patch to add backup manifests, but it also seems to have some
> potential more general use.
I'm not sure what the actual purpose of this feature yet, but ISTM that
the following change is necessary. Otherwise, "empty" stats information
is output even when --quiet is specified.
- if (config.stats == true)
+ if (config.stats == true && !config.quiet)
XLogDumpDisplayStats(&config, &stats);
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-04-03 02:28:27 | pgsql: Include information on buffer usage during planning phase, in EX |
| Previous Message | Robert Haas | 2020-04-03 01:11:41 | pgsql: pg_waldump: Add a --quiet option. |