| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Andy Fan <zhihuifan1213(at)163(dot)com> |
| Cc: | Nikita Malakhov <hukutoc(at)gmail(dot)com>, Michael Zhilin <m(dot)zhilin(at)postgrespro(dot)ru>, Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Shared detoast Datum proposal |
| Date: | 2024-03-03 20:41:18 |
| Message-ID: | d2e3ef5c-ac09-4b10-a99f-4c964b490f8c@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/3/24 07:10, Andy Fan wrote:
>
> Hi,
>
> Here is a updated version, the main changes are:
>
> 1. an shared_detoast_datum.org file which shows the latest desgin and
> pending items during discussion.
> 2. I removed the slot->pre_detoast_attrs totally.
> 3. handle some pg_detoast_datum_slice use case.
> 4. Some implementation improvement.
>
I only very briefly skimmed the patch, and I guess most of my earlier
comments still apply. But I'm a bit surprised the patch needs to pass a
MemoryContext to so many places as a function argument - that seems to
go against how we work with memory contexts. Doubly so because it seems
to only ever pass CurrentMemoryContext anyway. So what's that about?
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-03-03 21:14:49 | Re: pgsql: Improve performance of subsystems on top of SLRU |
| Previous Message | Tomas Vondra | 2024-03-03 20:29:42 | Re: Shared detoast Datum proposal |