Re: Why does logical replication launcher exit with exit code 1?

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why does logical replication launcher exit with exit code 1?
Date: 2017-08-02 20:38:40
Message-ID: d2b19fd7-9013-ca54-61a4-0e915009842f@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 8/1/17 20:20, Andres Freund wrote:
> Well, that's how it is for all bgworkers - maybe a better solution is to
> adjust that message in the postmaster rather than fiddle with the worker
> exist code? Seems like we could easily take pmStatus into account
> inside LogChildExit() and set the log level to DEBUG1 even for
> EXIT_STATUS_1 in that case? Additionally we probably should always log
> a better message for bgworkers exiting with exit 1, something about
> unregistering the worker or such.

Maybe it doesn't need to be logged at all (other than perhaps as DEBUG)?
A few months ago, people were complaining about too many messages about
background workers starting. Now we are having complaints about
messages about background workers stopping.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-08-02 20:40:38 Re: Partition-wise join for join between (declaratively) partitioned tables
Previous Message Robert Haas 2017-08-02 20:36:35 Re: [PATCH] Make ExplainBeginGroup()/ExplainEndGroup() public.