Re: Add missing tab completion for ALTER TABLE ADD COLUMN IF NOT EXISTS

From: Tomas Vondra <tomas(at)vondra(dot)me>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Karina Litskevich <litskevichkarina(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add missing tab completion for ALTER TABLE ADD COLUMN IF NOT EXISTS
Date: 2024-12-16 16:40:59
Message-ID: d24eb9b1-8156-4e3b-9c58-a80048ae6619@vondra.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/8/24 05:22, Kirill Reshke wrote:
> On Sun, 8 Dec 2024 at 03:35, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>>
>> Hi,
>> I took a quick look at this patch series, and it looks generally fine to
>> me. Barring objections, I'll get it committed. Yes, there's a couple
>> cosmetic details, and it needs a pgindent run, but I think I can take
>> care of that ...
>>
> Thank you for taking a look.
>
> PFA v6 with last Karina's review comments addressed.
>

Thanks. Pushed.

I went through the patches, and pushed them with some pretty minor
tweaks. Most of the work was about writing the commit messages. I
considered squashing the commits, but decided not to do that - each of
the 4 patches does tab completion for different command.

regards

--
Tomas Vondra

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-12-16 16:44:57 Standardizing the file header?
Previous Message Tom Lane 2024-12-16 16:21:23 Re: improve EXPLAIN for wide tables