| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Tristan Partin <tristan(at)neon(dot)tech>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add --check option to pgindent |
| Date: | 2023-12-20 22:38:40 |
| Message-ID: | d1f67d9f-106d-3a98-f6f6-bf79ddcdbbf1@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-12-20 We 11:05, Andrew Dunstan wrote:
>
> On 2023-12-19 Tu 08:57, Daniel Gustafsson wrote:
>> The posted v5 seems like a good compromise
>> I reckon.
>>
>> Andrew: When applying this, how do we synchronize with the buildfarm
>> to avoid
>> false negatives due to the BF using the wrong options?
>
>
> The only buildfarm animal involved here is koel, which I run, so the
> simplest way will be for me to commit the core patch and adjust the
> buildfarm code at the same time.
>
>
V5 seems to be the consensus. I went with that, but added in logic to
exit the loop early for --check if we're not also doing --diff.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-12-20 22:57:16 | Re: Built-in CTYPE provider |
| Previous Message | Jacob Burroughs | 2023-12-20 21:48:13 | Re: libpq compression (part 3) |