| From: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, andres(at)anarazel(dot)de |
| Cc: | jcasanov(at)systemguards(dot)com(dot)ec, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: START_REPLICATION SLOT causing a crash in an assert build |
| Date: | 2022-10-05 17:00:53 |
| Message-ID: | d1bd5065-ca79-d833-2d7d-0b0404589711@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/27/22 1:52 AM, Kyotaro Horiguchi wrote:
> Thanks!
>
> At Mon, 26 Sep 2022 19:53:02 -0700, Andres Freund <andres(at)anarazel(dot)de> wrote in
>> I wonder if the correct fix here wouldn't be to move the slotname out of
>> PgStat_StatReplSlotEntry?
>
> Ugh. Right. I thought its outer struct as purely the part for the
> common header. But we can freely place anything after the header
> part. I moved it to the outer struct. I didn't clear that part in
> pgstat_create_relation() because it is filled in immediately.
>
> The attached is that.
This is still listed as an open item[1] for v15. Does this fix proposed
address the issue?
Thanks,
Jonathan
[1] https://wiki.postgresql.org/wiki/PostgreSQL_15_Open_Items
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-10-05 17:14:45 | Re: [RFC] building postgres with meson - v13 |
| Previous Message | Alvaro Herrera | 2022-10-05 16:40:48 | Re: [BUG] parenting a PK constraint to a self-FK one (Was: Self FK oddity when attaching a partition) |