Re: save redundant code for pseudotype I/O functions

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: save redundant code for pseudotype I/O functions
Date: 2016-11-01 16:01:31
Message-ID: d0014805-67b8-8b81-02e4-86e0bd2b0888@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/28/16 9:25 AM, Tom Lane wrote:
> Would it be better to use CppAsString and CppConcat instead of directly
> using # and ##, for consistency with what we do elsewhere?

I modeled this after several similar places in gin and tsearch code,
which use ##:

contrib/btree_gin/btree_gin.c
src/backend/tsearch/wparser_def.c
src/backend/utils/adt/tsvector_op.c

Do people prefer the macros over this?

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-11-01 16:12:32 Re: Patch: Implement failover on libpq connect level.
Previous Message Peter Eisentraut 2016-11-01 15:58:56 pgsql: Add make rules to download raw Unicode mapping files