| From: | Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, pgsql-hackers(at)postgresql(dot)org |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Fix for FETCH FIRST syntax problems |
| Date: | 2018-05-20 13:38:50 |
| Message-ID: | d000efee-348c-0e31-4286-9732755b7d7e@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20/05/18 05:25, Andrew Gierth wrote:
> +select_fetch_first_value:
> + c_expr { $$ = $1; }
> + | '+' I_or_F_const
> + { $$ = (Node *) makeSimpleA_Expr(AEXPR_OP, "+", NULL, $2, @1); }
> + | '-' I_or_F_const
> + { $$ = doNegate($2, @1); }
I think there should be a comment for why you're accepting FCONST when
the value has to be integral.
--
Vik Fearing +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2018-05-20 19:26:50 | Re: Fix for FETCH FIRST syntax problems |
| Previous Message | Vik Fearing | 2018-05-20 11:07:04 | Re: Fix for FETCH FIRST syntax problems |