Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

Op 27-10-2021 om 18:02 schreef Gilles Darold:
>>
>> Otherwise, build, make check, chekc-world are OK.  Also the pdf builds
>> ok.
>
> Thanks Erik, new version v6 attached.

Hi,

Anther small thing: the test_decoding module was overlooked, I think.
Below is output from make check-world (this error does not occur in master)

Erik

============== running regression test queries ==============
test ddl ... FAILED 1210 ms
test xact ... ok 22 ms
test rewrite ... ok 176 ms
test toast ... ok 292 ms
test permissions ... ok 24 ms
test decoding_in_xact ... ok 23 ms
test decoding_into_rel ... ok 33 ms
test binary ... ok 16 ms
test prepared ... ok 21 ms
test replorigin ... ok 23 ms
test time ... ok 22 ms
test messages ... ok 26 ms
test spill ... ok 2407 ms
test slot ... ok 424 ms
test truncate ... ok 21 ms
test stream ... ok 31 ms
test stats ... ok 1097 ms
test twophase ... ok 46 ms
test twophase_stream ... ok 28 ms
============== shutting down postmaster ==============

=======================
1 of 19 tests failed.
=======================

The differences that caused some tests to fail can be viewed in the
file
"/home/aardvark/pg_stuff/pg_sandbox/pgsql.hide_column/contrib/test_decoding/regression.diffs".
A copy of the test summary that you see
above is saved in the file
"/home/aardvark/pg_stuff/pg_sandbox/pgsql.hide_column/contrib/test_decoding/regression.out".

../../src/makefiles/pgxs.mk:451: recipe for target 'check' failed
make[2]: *** [check] Error 1
make[2]: Leaving directory
'/home/aardvark/pg_stuff/pg_sandbox/pgsql.hide_column/contrib/test_decoding'
Makefile:94: recipe for target 'check-test_decoding-recurse' failed
make[1]: *** [check-test_decoding-recurse] Error 2
make[1]: Leaving directory
'/home/aardvark/pg_stuff/pg_sandbox/pgsql.hide_column/contrib'
GNUmakefile:71: recipe for target 'check-world-contrib-recurse' failed
make: *** [check-world-contrib-recurse] Error 2