| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: WIP: BRIN multi-range indexes |
| Date: | 2021-03-05 00:37:54 |
| Message-ID: | cf8fca26-0fdd-ac74-5dac-66a2ccb59f56@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Here is an updated version of the patch series, with a couple minor
changes/improvements.
1) adding bsearch_arg to src/port/
2) moving minmax/inclusion changes from 0002 to a separate patch 0003
I think we should either ditch the 0003 (i.e. keep the existing
opclasses unchanged) or commit 0003 (in which case I'd vote to just stop
supporting the old signature of the consistent function).
The remaining part that didn't get much review is the very last patch,
adding an option to ignore correlation for some BRIN opclases. This is
needed as the regular BRIN costing is quite sensitive to correlation,
and the cost gets way too high for poorly correlated data, making it
unlikely the index will be used. But handling such data sets efficiently
is the main point of those new opclasses. Any opinions on this?
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-introduce-bsearch_arg-20210305.patch | text/x-patch | 4.2 KB |
| 0002-Pass-all-scan-keys-to-BRIN-consistent-funct-20210305.patch | text/x-patch | 8.5 KB |
| 0003-Process-all-scan-keys-in-existing-BRIN-opcl-20210305.patch | text/x-patch | 15.4 KB |
| 0004-Move-IS-NOT-NULL-handling-from-BRIN-support-20210305.patch | text/x-patch | 23.1 KB |
| 0005-Optimize-allocations-in-bringetbitmap-20210305.patch | text/x-patch | 4.5 KB |
| 0006-BRIN-bloom-indexes-20210305.patch | text/x-patch | 127.5 KB |
| 0007-BRIN-minmax-multi-indexes-20210305.patch | text/x-patch | 238.9 KB |
| 0008-Ignore-correlation-for-new-BRIN-opclasses-20210305.patch | text/x-patch | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hannu Krosing | 2021-03-05 00:38:02 | Re: Extensibility of the PostgreSQL wire protocol |
| Previous Message | Tom Lane | 2021-03-05 00:36:18 | Re: macOS SIP, next try |