| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Konstantin Knizhnik <knizhnik(at)garret(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Sync scan & regression tests |
| Date: | 2023-08-31 10:12:42 |
| Message-ID: | cf476894-bbe1-fa0b-f413-f690c00ca0ad@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 31/08/2023 02:37, Melanie Plageman wrote:
> On Wed, Aug 30, 2023 at 5:15 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>>
>> I just looked at v15's code and I agree that the ss_report_location()
>> would be called even when the scan is finished. It wasn't intentional
>> that that was changed in v16, so I'm happy for your patch to be
>> applied and backpatched to 16. Thanks for digging into that.
>
> Yes, thanks for catching my mistake.
> LGTM.
Pushed, thanks for the reviews!
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-08-31 10:26:47 | Re: cataloguing NOT NULL constraints |
| Previous Message | Alvaro Herrera | 2023-08-31 10:02:39 | Re: cataloguing NOT NULL constraints |