Re: Separate GUC for replication origins

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: "vignesh C" <vignesh21(at)gmail(dot)com>
Cc: "Peter Eisentraut" <peter(at)eisentraut(dot)org>, "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>, "Masahiko Sawada" <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Separate GUC for replication origins
Date: 2025-03-14 00:54:40
Message-ID: ceebf8f4-709f-49b1-9b27-f2b1b4646d4e@app.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 13, 2025, at 11:10 AM, vignesh C wrote:
> Few comments:

Thanks for taking a look.

> 1) After selecting max_active_replication_origins setting in the
> SELECT query having order by, the first record returned will be the
> one with max_active_replication_origins, rather than the second
> record, because max_active_replication_origins appears before
> max_logical_replication_workers in the order.

Fixed.

> 2) I felt max_replication_slots must be max_active_replication_origins
> here in logical-replication.sgml:

Fixed.

--
Euler Taveira
EDB https://www.enterprisedb.com/

Attachment Content-Type Size
v6-0001-Separate-GUC-for-replication-origins.patch text/x-patch 26.9 KB
v6-0002-max_active_replication_origins-defaults-to-10.patch.nocfbot application/octet-stream 4.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2025-03-14 01:15:34 Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET
Previous Message Michael Paquier 2025-03-14 00:27:52 Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET