| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com> |
| Subject: | Re: A bug in mapping attributes in ATExecAttachPartition() |
| Date: | 2017-07-27 01:50:24 |
| Message-ID: | cee32590-68a7-8b56-5213-e07d9b8ab89e@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for looking at this again.
On 2017/07/26 23:31, Ashutosh Bapat wrote:
> On Wed, Jul 12, 2017 at 7:17 AM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>
>> Thanks for the review. Patch updated taking care of the comments.
>
> The patches still apply and compile. make check runs well. I do not
> have any further review comments. Given that they address a bug,
> should we consider those for v10?
At least patch 0001 does address a bug. Not sure if we can say that 0002
addresses a bug; it implements a feature that might be a
nice-to-have-in-PG-10.
Attaching rebased patches.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Cope-with-differing-attnos-in-ATExecAttachPartition-.patch | text/plain | 11.3 KB |
| 0002-Teach-ATExecAttachPartition-to-skip-validation-in-mo.patch | text/plain | 11.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-07-27 02:29:32 | Re: segfault in HEAD when too many nested functions call |
| Previous Message | Robert Haas | 2017-07-27 01:28:50 | Re: Transactions involving multiple postgres foreign servers |