| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: Reordering DISTINCT keys to match input path's pathkeys |
| Date: | 2024-11-22 08:39:02 |
| Message-ID: | cea712ca-d5db-432e-9170-bcb1ed3b95ee@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/13/24 13:49, Richard Guo wrote:
> On Mon, Oct 28, 2024 at 6:15 PM Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
>> On 6/7/24 16:46, Richard Guo wrote:
> I'm not sure about merging these two 'reordering' GUCs into one.
> While they may look similar, they apply to very different scenarios.
> However, I'm open to other suggestions.
I finally have passed through the code. It generally looks OK. Let me
only write a few words on tests.
I wonder if it would be possible to print only three rows instead of 10
to prove the DISTINCT's correctness.
Also, to stabilise tests with parallel workers, I would recommend
setting max_parallel_workers_per_gather into 1 and enabling
debug_parallel_query.
--
regards, Andrei Lepikhov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiro Ikeda | 2024-11-22 09:17:23 | Re: Adding skip scan (including MDAM style range skip scan) to nbtree |
| Previous Message | Erik Nordström | 2024-11-22 08:11:21 | Re: Changed behavior in rewriteheap |