From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs |
Date: | 2023-10-06 08:21:12 |
Message-ID: | ce962dbb-6d3a-7ac6-67ea-ad6b824cc2bf@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 26.09.23 16:51, Nazir Bilal Yavuz wrote:
>> Also note that there are also dependencies in the other direction. For
>> example, the psql help is compiled from XML DocBook sources. So your
>> other patch would also need to include similar changesInclude() clauses.
>
> If there are more cases like this, it may not be worth it. Instead, we can just:
>
> - Build the docs when the doc related files are changed (This still
> creates a dependency like you said).
>
> - Skip CI completely if the README files are changed.
>
> What are your opinions on these?
I don't have a good sense of what you are trying to optimize for. If
it's the mainline build-on-every-commit type, then I wonder how many
commits would really be affected by this. Like, how many commits touch
only a README file. If it's for things like the cfbot, then I think the
time-triggered builds would be more frequent than new patch versions, so
I don't know if these kinds of optimizations would affect anything.
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2023-10-06 08:37:28 | Re: Synchronizing slots from primary to standby |
Previous Message | Peter Eisentraut | 2023-10-06 08:10:59 | Re: Pre-proposal: unicode normalized text |