| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WaitForOlderSnapshots refactoring |
| Date: | 2018-08-21 15:11:12 |
| Message-ID: | ce18c8fa-4564-3f8d-c5bf-6dd2033f4a3b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20/08/2018 14:39, Andres Freund wrote:
>> The question is where to put it. This patch just leaves it static in
>> indexcmds.c, which doesn't help other uses. A sensible place might be a
>> new src/backend/commands/common.c. Or we make it non-static in
>> indexcmds.c when the need arises.
> Why not move it to procarray.c? Most of the referenced functionality
> resides there IIRC.
I was thinking about that, too. I thought that that would create a
circular dependency between lock.c and procarray.c, but seeing that
that's already the case, I guess it's OK. (lock.c includes procarray.h,
but procarray.c uses stuff from lock.h, even though it doesn't include
it directly.) I'll rework the patch accordingly.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-08-21 15:15:53 | Re: remove ATTRIBUTE_FIXED_PART_SIZE |
| Previous Message | Mark Wong | 2018-08-21 15:10:14 | Re: [GSoC] Summery of pg performance farm |