Re: ALTER TABLE lock downgrades have broken pg_upgrade

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: ALTER TABLE lock downgrades have broken pg_upgrade
Date: 2016-05-11 13:40:09
Message-ID: cddab88a-3a2b-cc78-9107-78af1ab33f7d@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/3/16 1:25 PM, Alvaro Herrera wrote:
> If we can put together a script that runs test.sh for various versions
> and then verifies the runs, we could use it in both buildfarm and
> coverage.

Not that that would be useless, but note that the value in this case
(and most others) comes from having a candidate object in the database
before upgrade that exercises the particular problem, mostly independent
of what version you upgrade from and to. So far the way to do that is
to leave "junk" in the regression test database, but that's clearly a
bit silly.

I think the way forward is to create a TAP test suite for pg_upgrade
that specifically exercises a lot of scenarios with small purpose-built
test databases.

Then, the problem of having to compare dump output across versions also
goes away more easily.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-05-11 13:40:28 Re: Add jsonb_compact(...) for whitespace-free jsonb to text
Previous Message Martín Marqués 2016-05-11 11:00:21 Minor documentation patch