| From: | "Joel Jacobson" <joel(at)compiler(dot)org> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org, "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids |
| Date: | 2021-04-23 07:30:47 |
| Message-ID: | cd7130ae-86fc-4bef-ba10-4abca1af6423@www.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 23, 2021, at 08:54, Joel Jacobson wrote:
> pg_describe_object | event trigger ddl_postgrest
> pg_identify_object | ("event trigger",,ddl_postgrest,ddl_postgrest)
> pg_identify_object_as_address | ("event trigger",{},{})
>
> I therefore think the evtname should be added to object_names.
Could it possibly be as simple to fix as the attached patch?
Not sure if the the string constructed by appendStringInfo() also needs to be adjusted.
With the patch, the example above returns:
pg_identify_object_as_address | ("event trigger",{ddl_postgrest},{})
/Joel
| Attachment | Content-Type | Size |
|---|---|---|
| fix-pg_identify_object_as_address-for-event-triggers.patch | application/octet-stream | 907 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-04-23 07:31:01 | Re: truncating timestamps on arbitrary intervals |
| Previous Message | Fujii Masao | 2021-04-23 07:30:27 | Re: wal stats questions |