From: | "Adrian Maier" <adrian(dot)maier(at)gmail(dot)com> |
---|---|
To: | "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [HACKERS] float8 regression failure (HEAD, cygwin) |
Date: | 2006-08-01 12:24:31 |
Message-ID: | cd30ef8c0608010524i45c5291v924e0839d6dab9a9@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On 01/08/06, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Adrian Maier wrote:
> > On 20/07/06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Apparently the regression test is comparing the results/float8.out
> > with expected/float8-small-is-zero.out because of the following line
> > in
> > src/test/regress/resultmap :
> > float8/i.86-pc-cygwin=float8-small-is-zero
> >
> > I've changed that line to :
> > float8/i.86-pc-cygwin=float8
> > and the regression test ended successfully : "All 100 tests passed."
> >
> > I don't know why there are several expected results for the float8 test,
> > depending on the platform. Is the modification ok?
> >
> > I've attached the patch, and cc'ed to pgsql-patches.
>
> The problem with this is that we have another Cygwin member on buildfarm
> which passes the tests happily, and will thus presumably fail if we make
> this patch. You are running Cygwin 1.5.21 and the other buildfarm member
> is running 1.5.19, so that is possibly the difference.
This is indeed a problem. It would be difficult or even impossible to
use different expected results for different versions of cygwin.
> Maybe we need to abandon trying to map float8 results exactly in the
> resultmap file, and just let pg_regress pick the best fit as we do with
> some other tests.
Oh, is it possible to do that? That sounds great. Which other tests
work like that?
Cheers,
Adrian Maier
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-08-01 12:25:57 | Re: [HACKERS] float8 regression failure (HEAD, cygwin) |
Previous Message | Bruce Momjian | 2006-08-01 12:18:30 | Re: Online index builds |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-08-01 12:25:57 | Re: [HACKERS] float8 regression failure (HEAD, cygwin) |
Previous Message | Andrew Dunstan | 2006-08-01 11:50:22 | Re: [HACKERS] float8 regression failure (HEAD, cygwin) |